Skip to content

[Website] Fix help layout grid#3883

Merged
cpojer merged 2 commits intojestjs:masterfrom
hramos:fix-help-layout-grid
Jun 26, 2017
Merged

[Website] Fix help layout grid#3883
cpojer merged 2 commits intojestjs:masterfrom
hramos:fix-help-layout-grid

Conversation

@hramos
Copy link
Contributor

@hramos hramos commented Jun 22, 2017

At some point, the CSS file lost these threeColumn styles. This restores the threeColumn layout used by GridBlock, specifically in core/JestHelp.js's use case.

@hramos hramos changed the title Fix help layout grid [Website] Fix help layout grid Jun 22, 2017
@codecov-io
Copy link

Codecov Report

Merging #3883 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3883      +/-   ##
==========================================
- Coverage   58.07%   57.63%   -0.45%     
==========================================
  Files         195      194       -1     
  Lines        6734     6782      +48     
  Branches        6        6              
==========================================
- Hits         3911     3909       -2     
- Misses       2820     2870      +50     
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-cli/src/TestRunner.js 25.3% <0%> (-3.16%) ⬇️
packages/jest-jasmine2/src/index.js 0% <0%> (ø) ⬆️
packages/jest-cli/src/runJest.js 0% <0%> (ø) ⬆️
packages/jest-jasmine2/src/queueRunner.js 100% <0%> (ø) ⬆️
packages/jest-jasmine2/src/setup-jest-globals.js 0% <0%> (ø) ⬆️
packages/jest-jasmine2/src/jasmine/Env.js 0% <0%> (ø) ⬆️
packages/jest-cli/src/reporters/SummaryReporter.js 22.58% <0%> (ø) ⬆️
...st-matchers/src/extractExpectedAssertionsErrors.js 13.33% <0%> (ø) ⬆️
packages/jest-cli/src/SearchSource.js 71.01% <0%> (ø) ⬆️
packages/jest-cli/src/testResultHelpers.js
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b0a07...af6cd6b. Read the comment docs.

@hramos hramos added the Website label Jun 23, 2017
@cpojer cpojer merged commit 2da093e into jestjs:master Jun 26, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* [Help Page] Change to four column layout

* Restore threeColumn GridBlock layout used in the Help page.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants