Skip to content

Commit 7317fdb

Browse files
felixtrzmeta-codesync[bot]
authored andcommitted
feat(three): migrate to super-three@0.181.0 and centralize version management
Summary: - Upgrade three.js from `super-three@0.177.0` to `0.181.0` across all packages and examples - Replace deprecated `RGBELoader` with `HDRLoader` in HDR texture loading - Centralize version management via pnpm overrides in root `package.json` - Make version check script dynamic by reading expected versions from `package.json` - Use wildcard `"three": "*"` in pnpm-managed packages (overrides enforce correct version) - Maintain explicit `npm:super-three@0.181.0` in npm-based examples for proper deduplication - Update documentation to reference `HDRLoader` instead of deprecated `RGBELoader` Reviewed By: zjm-meta Differential Revision: D87742740 Privacy Context Container: L1334777 fbshipit-source-id: 9d7de697f5a2091c9de247b219a7994139f5de68
1 parent 4cd9ab4 commit 7317fdb

File tree

13 files changed

+111
-61
lines changed

13 files changed

+111
-61
lines changed

docs/concepts/three-basics/meshes-geometry-materials.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,10 @@ IWSDK provides good default lighting:
253253
For realistic reflections and lighting:
254254

255255
```ts
256-
import { RGBELoader, PMREMGenerator } from '@iwsdk/core';
256+
import { HDRLoader } from 'three/examples/jsm/loaders/HDRLoader.js';
257+
import { PMREMGenerator } from '@iwsdk/core';
257258

258-
const loader = new RGBELoader();
259+
const loader = new HDRLoader();
259260
const pmremGenerator = new PMREMGenerator(world.renderer);
260261

261262
loader.load('/environments/sunset.hdr', (texture) => {

examples/audio/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"@iwsdk/core": "file:../../packages/core/iwsdk-core.tgz",
1717
"@pmndrs/uikit-horizon": "^1.0.60",
1818
"@pmndrs/uikit-lucide": "^1.0.60",
19-
"three": "npm:super-three@0.177.0"
19+
"three": "npm:super-three@0.181.0"
2020
},
2121
"devDependencies": {
2222
"@iwsdk/vite-plugin-gltf-optimizer": "file:../../packages/vite-plugin-gltf-optimizer/iwsdk-vite-plugin-gltf-optimizer.tgz",

examples/grab/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"dependencies": {
1616
"@iwsdk/core": "file:../../packages/core/iwsdk-core.tgz",
17-
"three": "npm:super-three@0.177.0"
17+
"three": "npm:super-three@0.181.0"
1818
},
1919
"devDependencies": {
2020
"@iwsdk/vite-plugin-gltf-optimizer": "file:../../packages/vite-plugin-gltf-optimizer/iwsdk-vite-plugin-gltf-optimizer.tgz",

examples/locomotion/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"@iwsdk/core": "file:../../packages/core/iwsdk-core.tgz",
1717
"@pmndrs/uikit-horizon": "^1.0.60",
1818
"@pmndrs/uikit-lucide": "^1.0.60",
19-
"three": "npm:super-three@0.177.0"
19+
"three": "npm:super-three@0.181.0"
2020
},
2121
"devDependencies": {
2222
"@iwsdk/vite-plugin-gltf-optimizer": "file:../../packages/vite-plugin-gltf-optimizer/iwsdk-vite-plugin-gltf-optimizer.tgz",

examples/physics/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
},
1515
"dependencies": {
1616
"@iwsdk/core": "file:../../packages/core/iwsdk-core.tgz",
17-
"three": "npm:super-three@0.177.0"
17+
"three": "npm:super-three@0.181.0"
1818
},
1919
"devDependencies": {
2020
"@iwsdk/vite-plugin-gltf-optimizer": "file:../../packages/vite-plugin-gltf-optimizer/iwsdk-vite-plugin-gltf-optimizer.tgz",

examples/scene-understanding/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"dependencies": {
1616
"@iwsdk/core": "file:../../packages/core/iwsdk-core.tgz",
1717
"patch-package": "^8.0.1",
18-
"three": "npm:super-three@0.177.0"
18+
"three": "npm:super-three@0.181.0"
1919
},
2020
"devDependencies": {
2121
"@iwsdk/vite-plugin-gltf-optimizer": "file:../../packages/vite-plugin-gltf-optimizer/iwsdk-vite-plugin-gltf-optimizer.tgz",

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"@rollup/plugin-terser": "^0.4.4",
5858
"@rollup/plugin-typescript": "^11.1.6",
5959
"@types/node": "^20.0.0",
60-
"@types/three": "^0.177.0",
60+
"@types/three": "^0.181.0",
6161
"@types/webxr": "^0.5.8",
6262
"@typescript-eslint/eslint-plugin": "^5.55.0",
6363
"@typescript-eslint/parser": "^5.62.0",
@@ -80,7 +80,8 @@
8080
},
8181
"pnpm": {
8282
"overrides": {
83-
"three": "npm:super-three@0.177.0",
83+
"three": "npm:super-three@0.181.0",
84+
"@types/three": "0.181.0",
8485
"three-mesh-bvh": "^0.9.1",
8586
"axios": "^1.12.0"
8687
}

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"@pmndrs/uikitml": "^0.1.12",
4242
"@preact/signals-core": "^1.11.0",
4343
"elics": "^3.3.0",
44-
"three": "npm:super-three@0.177.0",
44+
"three": "*",
4545
"three-mesh-bvh": "^0.9.1"
4646
},
4747
"engines": {

packages/core/src/asset/loaders/hdr-texture-loader.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77

88
import { EXRLoader } from 'three/examples/jsm/loaders/EXRLoader.js';
9-
import { RGBELoader } from 'three/examples/jsm/loaders/RGBELoader.js';
9+
import { HDRLoader } from 'three/examples/jsm/loaders/HDRLoader.js';
1010
import {
1111
EquirectangularReflectionMapping,
1212
LoadingManager,
@@ -18,11 +18,11 @@ import { CacheManager } from '../cache-manager.js';
1818
* @category Assets
1919
*/
2020
export class HDRTextureAssetLoader {
21-
private static rgbeLoader: RGBELoader;
21+
private static hdrLoader: HDRLoader;
2222
private static exrLoader: EXRLoader;
2323

2424
static init(loadingManager: LoadingManager): void {
25-
this.rgbeLoader = new RGBELoader(loadingManager);
25+
this.hdrLoader = new HDRLoader(loadingManager);
2626
this.exrLoader = new EXRLoader(loadingManager);
2727
}
2828

@@ -68,7 +68,7 @@ export class HDRTextureAssetLoader {
6868
if (isEXR) {
6969
this.exrLoader.load(url, onLoad, undefined, onError);
7070
} else {
71-
this.rgbeLoader.load(url, onLoad, undefined, onError);
71+
this.hdrLoader.load(url, onLoad, undefined, onError);
7272
}
7373
});
7474

packages/starter-assets/starter-template/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@
1010
},
1111
"dependencies": {
1212
"@iwsdk/core": "file:../packages/core/iwsdk-core.tgz",
13-
"three": "npm:super-three@0.177.0"
13+
"three": "npm:super-three@0.181.0"
1414
},
1515
"devDependencies": {
1616
"@iwsdk/vite-plugin-gltf-optimizer": "file:../packages/vite-plugin-gltf-optimizer/iwsdk-vite-plugin-gltf-optimizer.tgz",
1717
"@iwsdk/vite-plugin-iwer": "file:../packages/vite-plugin-iwer/iwsdk-vite-plugin-iwer.tgz",
1818
"@iwsdk/vite-plugin-metaspatial": "file:../packages/vite-plugin-metaspatial/iwsdk-vite-plugin-metaspatial.tgz",
1919
"@iwsdk/vite-plugin-uikitml": "file:../packages/vite-plugin-uikitml/iwsdk-vite-plugin-uikitml.tgz",
20-
"@types/three": "^0.178.1",
20+
"@types/three": "*",
2121
"typescript": "^5.5.0",
2222
"vite": "^7.1.4",
2323
"vite-plugin-mkcert": "^1.17.0"

0 commit comments

Comments
 (0)