Improve shape field access error message

Wilfred · facebook-github-bot · commit c2b2433f9091 · 2022-08-25T19:39:34.000-07:00
Summary: Previously we discussed "constant strings" which were being confused with class constants. Prefer "string literal" terminology.

Reviewed By: periodic1236

Differential Revision: D39044065

fbshipit-source-id: 20bf743f08137e97d9e14573735777cff03c8b9d
diff --git a/hphp/hack/src/errors/typing_error.ml b/hphp/hack/src/errors/typing_error.ml
@@ -391,7 +391,7 @@ module Primary = struct
       let claim =
         lazy
           ( pos,
-            "Was expecting a constant string, class constant, or int (for shape access)"
+            "Shape access requires a string literal, integer literal, or a class constant"
           )
       in
       (Error_code.InvalidShapeFieldName, claim, lazy [], [])
diff --git a/hphp/hack/test/typecheck/shape_key_exists8.php.exp b/hphp/hack/test/typecheck/shape_key_exists8.php.exp
@@ -1,2 +1,2 @@
 File "shape_key_exists8.php", line 6, characters 30-35:
-Was expecting a constant string, class constant, or int (for shape access) (Typing[4051])
+Shape access requires a string literal, integer literal, or a class constant (Typing[4051])
diff --git a/hphp/hack/test/typecheck/shape_remove_key5.php.exp b/hphp/hack/test/typecheck/shape_remove_key5.php.exp
@@ -1,2 +1,2 @@
 File "shape_remove_key5.php", line 13, characters 31-32:
-Was expecting a constant string, class constant, or int (for shape access) (Typing[4051])
+Shape access requires a string literal, integer literal, or a class constant (Typing[4051])

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ module Primary = struct`
`391`	`391`	`let claim =`
`392`	`392`	`lazy`
`393`	`393`	`( pos,`
`394`		`- "Was expecting a constant string, class constant, or int (for shape access)"`
	`394`	`+ "Shape access requires a string literal, integer literal, or a class constant"`
`395`	`395`	`)`
`396`	`396`	`in`
`397`	`397`	`(Error_code.InvalidShapeFieldName, claim, lazy [], [])`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`File "shape_key_exists8.php", line 6, characters 30-35:`
`2`		`-Was expecting a constant string, class constant, or int (for shape access) (Typing[4051])`
	`2`	`+Shape access requires a string literal, integer literal, or a class constant (Typing[4051])`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`File "shape_remove_key5.php", line 13, characters 31-32:`
`2`		`-Was expecting a constant string, class constant, or int (for shape access) (Typing[4051])`
	`2`	`+Shape access requires a string literal, integer literal, or a class constant (Typing[4051])`