Skip to content

chore: fix codesandbox default privacy#9993

Merged
slorber merged 2 commits into
mainfrom
slorber/public-sandbox
Mar 29, 2024
Merged

chore: fix codesandbox default privacy#9993
slorber merged 2 commits into
mainfrom
slorber/public-sandbox

Conversation

@slorber

@slorber slorber commented Mar 28, 2024

Copy link
Copy Markdown
Collaborator

Motivation

CodeSandbox repros we receive lately are private by default, which is annoying:

image

Apparently, new query string options have been implemented to prevent this, so let's figure what is the best for our use case.

https://twitter.com/CompuIves/status/1773028692752539825

CleanShot 2024-03-28 at 10 41 25

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 28, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 28, 2024
@netlify

netlify Bot commented Mar 28, 2024

Copy link
Copy Markdown

[V2]

Name Link
🔨 Latest commit 8308674
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6606f9fa3015890008fa06f7
😎 Deploy Preview https://deploy-preview-9993--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions

github-actions Bot commented Mar 28, 2024

Copy link
Copy Markdown

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 42 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 56 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 68 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 61 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 68 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber added pr: ignore This PR is not meaningful enough to appear in the changelog. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Mar 29, 2024
@slorber slorber marked this pull request as ready for review March 29, 2024 17:27
@slorber slorber requested a review from Josh-Cena as a code owner March 29, 2024 17:27
@slorber

slorber commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator Author

Note to self: from this twitter conversation I understand we can use the new ?fork=true&privacy=public query string.

Using fork=true is not an ideal general UX to me because users get presented with a modal immediately even before seeing Docusaurus running in a sandbox, so let's only use privacy=public alone

@slorber slorber merged commit 70415a4 into main Mar 29, 2024
@slorber slorber deleted the slorber/public-sandbox branch March 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants