feat(theme): add queryString option to localeDropdown#8915
Merged
slorber merged 2 commits intofacebook:mainfrom Apr 21, 2023
ceolinwill:add-query-string
Merged
feat(theme): add queryString option to localeDropdown#8915slorber merged 2 commits intofacebook:mainfrom ceolinwill:add-query-string
slorber merged 2 commits intofacebook:mainfrom
ceolinwill:add-query-string
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
approved these changes
Apr 21, 2023
Collaborator
slorber
left a comment
There was a problem hiding this comment.
Thanks 👍
That looks good enough for me and is not too risky to merge.
We'll look into using this on our own website later and when Netlify edge functions are out of beta
This was referenced Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR adds a
queryStringoption to thelocaleDropdownconsidering @slorber's review for #5890Test Plan
@slorber mentioned we should dogfood it but I wasn't sure how do it. I can think of two ways for dogfooding it:
queryStringoption and uses Netlify Edge Functions to set a cookie to remember a user's preference.queryStringis properly appended to the URL.I manually tested the following cases:
undefined.I'm happy to write tests for those cases (and additional ones I didn't think of) but I'll need some pointers on how to get started.
Test links
Deploy preview: https://deploy-preview-8915--docusaurus-2.netlify.app/
Related issues/PRs
#5890
#5839 (reply in thread)