Fix bug unable to search docs according to its version#797
Merged
endiliey merged 1 commit intofacebook:masterfrom Jun 23, 2018
Merged
Fix bug unable to search docs according to its version#797endiliey merged 1 commit intofacebook:masterfrom
endiliey merged 1 commit intofacebook:masterfrom
Conversation
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 105bd8e |
Contributor
Author
|
It's quite a serious bug actually. It's just that not many user know that they can refine their algolia search 😢 because it's quite complicated (you have to learn algolia config 😂 ) Btw I'll merge this & sleep. I'll fix the other PR tmrw @yangshun |
This was referenced Jun 24, 2018
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As per https://docusaurus.io/docs/en/search#extra-search-options
However, the current implementation is currently broken, while algolia docsearch expect something like '1.3.0', we provide 'current' as the version if we are currently in the latest stable version.
https://github.com/facebook/Docusaurus/blob/c5661b0e1e131803709852adc2283fb4894aabcc/lib/core/Site.js#L36-L43
https://github.com/facebook/Docusaurus/blob/c5661b0e1e131803709852adc2283fb4894aabcc/lib/core/Site.js#L130-L134
Docusaurus.io docsearch is working fine because we don't search according to current version.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Use this algolia index for testing and use version facetfilters
Before (search is broken)

After this PR (search according to current version)
