fix: include all branch tips for shallow clone in deploy command#5828
Merged
slorber merged 1 commit intoOct 29, 2021
Merged
Conversation
|
✔️ [V2] 🔨 Explore the source changes: 61af1c4 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617c141dfd21db00079e8e4e 😎 Browse the preview: https://deploy-preview-5828--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5828--docusaurus-2.netlify.app/ |
Collaborator
|
Thanks, makes sense to me. Should be a bit slower though, but probably not a big deal. @nlfurniss let me know if you don't like this solution |
Contributor
Seems good to me, sorry for causing an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5827
Motivation
Shallow clone of repository (introduced in #5748) fetches the default branch only.
From Git - git-clone Documentation:
This causes
git checkoutof the deployment branch to fail (with version2.0.0-beta.8of@docusaurus/core):As a result of this, the command will go on to attempt to force push the orphan branch, and thereby overwrite any existing commits on the deployment branch (unless there is a branch protection rule preventing force pushes, in which case the deployment will fail altogether).
Adding
--no-single-branchto the command should solve this issue.An alternative solution with
--branch ${deploymentBranch}could probably also be used here.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested command locally.
Related PRs
#5748