Use cssnano to minify main CSS file#569
Merged
yangshun merged 5 commits intofacebook:masterfrom Apr 17, 2018
yangshun:cssnano
Merged
Use cssnano to minify main CSS file#569yangshun merged 5 commits intofacebook:masterfrom yangshun:cssnano
yangshun merged 5 commits intofacebook:masterfrom
yangshun:cssnano
Conversation
JoelMarcey
approved these changes
Apr 17, 2018
Contributor
JoelMarcey
left a comment
There was a problem hiding this comment.
Love this -- something that can be noticeable by users and devs alike, I think:
❤️
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As a good front end practice, assets should be minified before sending them down to the browser. First part of #568.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
This addition does not affect development workflow, only the build step. Ran the build step locally and served the static files using a Python webserver.
Before
After
The minified CSS is 30.4kb, a reduction of 7.7kb from the original 38.1kb (20% savings).
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)