feat(v2): add tag filters to showcase page#4515
Merged
slorber merged 19 commits intofacebook:masterfrom Apr 22, 2021
Merged
Conversation
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
|
[V1] Built with commit 7c6c060 |
|
[V2] Built with commit 7c6c060 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4515--docusaurus-2.netlify.app/ |
slorber
requested changes
Mar 25, 2021
Collaborator
slorber
left a comment
There was a problem hiding this comment.
thanks
that's the idea but you should use React state and embrace the React way of doing things ;)
slorber
reviewed
Mar 31, 2021
lex111
reviewed
Apr 11, 2021
Contributor
lex111
left a comment
There was a problem hiding this comment.
We definitely don't need to show tags with empty sites, for example:
And ideally I'd rather see human readable labels something like that:
Collaborator
|
Hi @lisa761 I'm completing this PR and going to merge it tomorrow, please don't add new commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
closes #4238
Have you read the Contributing Guidelines on pull requests?
Yes
Additional Information
Right now, I am trying to update the sites rendered by using
filteredUsers = users.filter((user) => user.tags.includes(selectedTags)).But this does not seem to work as
includesis only defined on arrays, and althoughuser.tagsis an array in user.js it appears to be treated as an object inside thefilterfunction.There are two ways to go about this:
includesLet me know if any of these work or if there is another better way to go about this.