perf(v2): reduce amount of component updates while scrolling#4473
Merged
slorber merged 1 commit intofacebook:masterfrom Mar 22, 2021
Merged
perf(v2): reduce amount of component updates while scrolling#4473slorber merged 1 commit intofacebook:masterfrom
slorber merged 1 commit intofacebook:masterfrom
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 31ccd9f https://app.netlify.com/sites/docusaurus-1/deploys/6054e6ac0d0909000862857b |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 31ccd9f |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4473--docusaurus-2.netlify.app/ |
Contributor
Author
|
There is actually more potential for optimization here, as we could add throttle to scroll event |
lex111
approved these changes
Mar 19, 2021
Contributor
lex111
left a comment
There was a problem hiding this comment.
Awesome, thanks for fixing my unoptimized code! 👏
Collaborator
|
thanks, that looks good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change limits amount of NavBar component updates by not updating it on every keyframe while user scroll through website
fixes #4454
Chrome
New "performance"
Old "performance"
Firefox
New flame chart
Old flame chart
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
open website in browser and start scrolling