Skip to content

refactor(v2): add missing types to theme-classic useTheme#4467

Merged
slorber merged 1 commit intofacebook:masterfrom
armano2:types/useTheme
Mar 19, 2021
Merged

refactor(v2): add missing types to theme-classic useTheme#4467
slorber merged 1 commit intofacebook:masterfrom
armano2:types/useTheme

Conversation

@armano2
Copy link
Copy Markdown
Contributor

@armano2 armano2 commented Mar 19, 2021

Motivation

improve types

Have you read the Contributing Guidelines on pull requests?

yes

@armano2 armano2 requested review from lex111 and slorber as code owners March 19, 2021 12:01
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 19, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 19, 2021

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 19, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit ba7c6d3

https://deploy-preview-4467--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4467--docusaurus-2.netlify.app/

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 19, 2021
@slorber slorber merged commit 61548d3 into facebook:master Mar 19, 2021
@armano2 armano2 deleted the types/useTheme branch March 19, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants