Skip to content

fix(v2): Fix i18n staging deployment due to json typo#4461

Merged
slorber merged 1 commit intomasterfrom
slorber/fix-staging-i18n-deployment
Mar 18, 2021
Merged

fix(v2): Fix i18n staging deployment due to json typo#4461
slorber merged 1 commit intomasterfrom
slorber/fix-staging-i18n-deployment

Conversation

@slorber
Copy link
Copy Markdown
Collaborator

@slorber slorber commented Mar 18, 2021

Motivation

malformed json prevents usage of the korean locale

(+ make staging i18n faster by removing versioning)

@slorber slorber requested a review from lex111 as a code owner March 18, 2021 18:04
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 18, 2021
@slorber slorber added pr: bug fix This PR fixes a bug in a past release. and removed CLA Signed Signed Facebook CLA labels Mar 18, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 18, 2021

[V1] Deploy preview success

Built with commit 8af4553

https://deploy-preview-4461--docusaurus-1.netlify.app

@github-actions
Copy link
Copy Markdown

Size Change: 0 B

Total Size: 575 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB 0 B
website/build/assets/js/main.********.js 401 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.8 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.7 kB 0 B

compressed-size-action

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 18, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 8af4553

https://deploy-preview-4461--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4461--docusaurus-2.netlify.app/

@slorber slorber merged commit 892d832 into master Mar 18, 2021
@slorber slorber deleted the slorber/fix-staging-i18n-deployment branch August 17, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants