chore(v2): Fix more linter warnings#4450
Merged
slorber merged 1 commit intofacebook:masterfrom Mar 18, 2021
SamChou19815:more-linter-warning-fix
Merged
chore(v2): Fix more linter warnings#4450slorber merged 1 commit intofacebook:masterfrom SamChou19815:more-linter-warning-fix
slorber merged 1 commit intofacebook:masterfrom
SamChou19815:more-linter-warning-fix
Conversation
SamChou19815
commented
Mar 17, 2021
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 71a5973 https://app.netlify.com/sites/docusaurus-1/deploys/6052541450b74000076aca70 |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 71a5973 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4450--docusaurus-2.netlify.app/classic/ |
Collaborator
|
Thanks for the cleanup :) LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix more linter warnings.
152 warnings -> 51 warnings.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Most of the changes are type-only, so check CI status.
For slight regex tweaks, I commented below on how they are already covered by existing tests.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)