Conversation
|
[V1] Deploy preview success Built with commit b49ebe3 |
|
Deploy preview for docusaurus-2 ready! Built with commit b49ebe3 |
|
Size Change: 0 B Total Size: 575 kB ℹ️ View Unchanged
|
# Conflicts: # website/versioned_docs/version-2.0.0-alpha.70/api/plugins/plugin-ideal-image.md # website/versioned_docs/version-2.0.0-alpha.70/sidebar.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have tests and lint running on CircleCI while most of the other things are on GH actions: let's move everything to GH actions as it's simpler and better integrated to Git.
(The v1 site remains deployed with CircleCI for now, until we switch to v1.docusaurus.io that is already on Netlify)
The linter does not lint the docs correctly.
The Netlify deploy preview builds too many previews and takes too much time, and block merges, while we often don't need to check the alternative deploys.
Let's just deploy the v2 site, and move alternate deploys to GH actions. I think just building the alternate deploys is good enough and we don't really need a preview anyway, until we have a real theme gallery.
Also:
pathsto filter PR executions