polish(v2): [theme-classic] update French translation and base.json#4358
polish(v2): [theme-classic] update French translation and base.json#4358slorber merged 2 commits intofacebook:masterfrom MisterFISHUP:fr-translation
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 5cd28cd https://app.netlify.com/sites/docusaurus-1/deploys/6043a18cd42c6c000798c99f |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 5cd28cd |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4358--docusaurus-2.netlify.app/classic/ |
| "theme.CodeBlock.copy___DESCRIPTION": "The copy button label on code blocks", | ||
| "theme.CodeBlock.copyButtonAriaLabel": "Copy code to clipboard", | ||
| "theme.CodeBlock.copyButtonAriaLabel___DESCRIPTION": "The ARIA label for copy code blocks button", | ||
| "theme.CodeBlock.copy___DESCRIPTION": "The copy button label on code blocks", |
There was a problem hiding this comment.
base is auto-generated so you should not update it, it will be reverted anyway
Will see how to update the auto-gen script to fix this, thanks!
| "theme.SearchPage.documentsFound.plurals": "Un document trouvé|{count} documents trouvés", | ||
| "theme.SearchPage.emptyResultsTitle": "Rechercher dans la documentation", | ||
| "theme.SearchPage.existingResultsTitle": "Rechercher des résultats pour \"{query}\"", | ||
| "theme.SearchPage.existingResultsTitle": "Résultats de recherche pour « {query} »", |
| "theme.blog.post.readMore": "Lire plus", | ||
| "theme.blog.post.readingTime.plurals": "Une minute de lecture|{readingTime} minutes de lecture", | ||
| "theme.blog.tagTitle": "{nPosts} taggés avec \"{tagName}\"", | ||
| "theme.blog.tagTitle": "{nPosts} tagués avec « {tagName} »", |
There was a problem hiding this comment.
not easy to translate the "tag" concept in french. Not sure "taguer" verb is the best as imho it's more relevant for street art, but tagger is not great either 🤔 will merge this but if we have a better translation later we may revisit
There was a problem hiding this comment.
will note to add plurals syntax for this title
There was a problem hiding this comment.
Thanks for noting the plural agreement issue :)
taggés -> tagués is just a more adaptive spelling that reflects the pronunciation if I'm not mistaken.
|
thanks :) |
Motivation
fr.json(spellings, punctuations, etc). I also believe "Search results for" is a noun, not a verb/action "To search results for", so I changed "Rechercher des résultats" to "Résultats de recherche".base.json: move the linetheme.CodeBlock.copy___DESCRIPTIONto the right place.Two questions
{nPosts}intheme.blog.tagTitlecould be a bit tricky since the "s" in the French word "tagués" in{nPosts} tagués avecdepends on whether n>1 (adjective declension). That is to say, the current French translation won't work well if there is only one post tagged [with something], and it's possible that similar problems occur in other languages. I think using the i18n syntax with|and not using{nPosts}can easily solve the problem, even though this would make this line much longer.collapseButtonseems to have the same value fortitleandAriaLabelinbase.jsonand in all the current translation files as well. Same forexpandButton. Maybe we can merge them into just one key, likecollapseButtonTitleAndAriaLabel?Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
N/A
Related PRs
N/A but not sure