Skip to content

fix(v2): fix update code translations script + update some translations#4349

Merged
slorber merged 1 commit intomasterfrom
slorber/fix-update-code-translations-script
Mar 5, 2021
Merged

fix(v2): fix update code translations script + update some translations#4349
slorber merged 1 commit intomasterfrom
slorber/fix-update-code-translations-script

Conversation

@slorber
Copy link
Copy Markdown
Collaborator

@slorber slorber commented Mar 4, 2021

Motivation

The update-code-translations script was broken due to my addition of the ___DESCRIPTION in each message in base.json

Also remove/migrate some legacy translations

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 4, 2021
@slorber slorber requested a review from lex111 as a code owner March 4, 2021 18:28
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 4, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 4, 2021

[V1] Deploy preview success

Built with commit d1e6b4f

https://deploy-preview-4349--docusaurus-1.netlify.app

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 4, 2021

Deploy preview for docusaurus-2 ready!

Built with commit d1e6b4f

https://deploy-preview-4349--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4349--docusaurus-2.netlify.app/classic/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2021

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.4 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@slorber slorber merged commit 4f41980 into master Mar 5, 2021
@slorber slorber deleted the slorber/fix-update-code-translations-script branch August 17, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants