Skip to content

misc: restore build size bot#4337

Merged
slorber merged 2 commits intomasterfrom
slorber/restore-build-size-bot
Mar 3, 2021
Merged

misc: restore build size bot#4337
slorber merged 2 commits intomasterfrom
slorber/restore-build-size-bot

Conversation

@slorber
Copy link
Copy Markdown
Collaborator

@slorber slorber commented Mar 3, 2021

After investigating a security issue using pull_request_target, we decided to finally keep build size bot but using pull_request.

It solves the security issue, but this means the build size bot won't be able to post a PR comment if the PR is from a fork.

See preactjs/compressed-size-action#54
See https://securitylab.github.com/research/github-actions-preventing-pwn-requests

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 3, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 3, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 3, 2021

[V1] Deploy preview success

Built with commit 032886a

https://deploy-preview-4337--docusaurus-1.netlify.app

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 3, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 032886a

https://deploy-preview-4337--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4337--docusaurus-2.netlify.app/classic/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2021

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@slorber slorber merged commit 4dad3bf into master Mar 3, 2021
@yangshun yangshun deleted the slorber/restore-build-size-bot branch March 3, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants