Skip to content

docs(v2): add ocpeasy to users#4331

Merged
slorber merged 1 commit intofacebook:masterfrom
ocpeasy:docv2-ocpeasy-user
Mar 3, 2021
Merged

docs(v2): add ocpeasy to users#4331
slorber merged 1 commit intofacebook:masterfrom
ocpeasy:docv2-ocpeasy-user

Conversation

@dbrrt
Copy link
Copy Markdown
Contributor

@dbrrt dbrrt commented Mar 3, 2021

Motivation

Adding ocpeasy project to the showcase/users section.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Starting the website should display OCPeasy in the showcase part, including ocpeasy.png preview.

Related PRs

N/A

@dbrrt dbrrt requested review from lex111 and slorber as code owners March 3, 2021 08:17
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @dbrrt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 3, 2021

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 3, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit ff16d7c

https://deploy-preview-4331--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4331--docusaurus-2.netlify.app/classic/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2021

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 3, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 3, 2021
Copy link
Copy Markdown
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

preview: require('./showcase/ocpeasy.png'),
website: 'https://www.ocpeasy.org',
source: 'https://github.com/ocpeasy/website',
tags: ['design'],
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tags: ['design'],
tags: [],

removing this as it's reserved for sites having a custom design

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to commit to your PR so please accept my suggestion so that I can merge

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to merge and fix this in another pr

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slorber Just saw your message, thanks for that!

@slorber slorber merged commit 6c73f51 into facebook:master Mar 3, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants