docs(v2): Fix examples by importing React#4297
docs(v2): Fix examples by importing React#4297slorber merged 1 commit intofacebook:masterfrom roydukkey:patch-1
Conversation
|
Hi @roydukkey! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 90b3f9c https://app.netlify.com/sites/docusaurus-1/deploys/60385219f286b70007f00660 |
|
Not going to sign CLA. You're welcome to merge this or create a new PR with the same changes. |
|
Size Change: 0 B Total Size: 532 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 90b3f9c |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4297--docusaurus-2.netlify.app/classic/ |
|
Make sense thanks. Can you please sign the CLA? (it's a FB legal requirement) |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Motivation
Code examples fail without
import React from 'react';Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tried implementing on my project with the copied code from docs.
yarn startsucceeded, but served blank screen.Related PRs
Didn't find any.