fix(v2): Code blocks should be LTR by default#4277
Merged
Conversation
|
[V1] Deploy preview success Built with commit 7528bb3 |
|
Deploy preview for docusaurus-2 ready! Built with commit 7528bb3 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4277--docusaurus-2.netlify.app/classic/ |
|
Size Change: +43 B (0%) Total Size: 544 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Code blocks should rather be LTR by default.
Using RTLCSS ignore directive to force the RTL style: https://rtlcss.com/learn/usage-guide/control-directives/
Not totally sure RTL code blocks make any sense, but asked a question here: shadeed/rtl-styling#13
Added the language as className in case the user wants to override this on a per-language basis