refactor(v2): introduce Seo component for internal using#4243
Merged
Conversation
dc11c1f to
3174173
Compare
lex111
commented
Feb 18, 2021
|
[V1] Deploy preview success Built with commit dc11c1f |
|
Size Change: +15 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
|
[V1] Deploy preview success Built with commit 3174173 |
|
Deploy preview for docusaurus-2 ready! Built with commit dc11c1f |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4243--docusaurus-2.netlify.app/classic/ |
|
Deploy preview for docusaurus-2 ready! Built with commit 3174173 |
Collaborator
|
I'll merge this refactor for now, but not 100% sure we'll keep this Seo abstraction in the long term, have some other ideas I'd like to explore for this and would prefer a more "fine-grained" approach instead of having all SEO metas go through a unique Seo or Layout component |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid a bit of code duplication by creating new general component for adding various SEO things (only for use inside our codebase for now).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)