Skip to content

fix(v2): fix website versions page#4234

Merged
lex111 merged 1 commit intomasterfrom
slorber/fix-versions-page
Feb 17, 2021
Merged

fix(v2): fix website versions page#4234
lex111 merged 1 commit intomasterfrom
slorber/fix-versions-page

Conversation

@slorber
Copy link
Copy Markdown
Collaborator

@slorber slorber commented Feb 17, 2021

Motivation

The current versions page is wrong:

image

This is likely because we use a little trick in dev so what you see in dev and prod is not 100% identical:

lastVersion: isDev ? 'current' : undefined,

I've made it so that the versions page show decent infos in both cases.

Dev:

image

Prod:

image

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 17, 2021
@slorber slorber requested a review from lex111 as a code owner February 17, 2021 11:57
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 17, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 17, 2021

[V1] Deploy preview success

Built with commit 254428e

https://deploy-preview-4234--docusaurus-1.netlify.app

@github-actions
Copy link
Copy Markdown

Size Change: +14 B (0%)

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB +1 B (0%)

compressed-size-action

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 17, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 254428e

https://deploy-preview-4234--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4234--docusaurus-2.netlify.app/classic/

@lex111 lex111 merged commit 4ccd9a3 into master Feb 17, 2021
@lex111
Copy link
Copy Markdown
Contributor

lex111 commented Feb 17, 2021

@slorber thanks!

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/fix-versions-page branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants