docs(v2): Removing wrong parenthesis on image variable#4226
docs(v2): Removing wrong parenthesis on image variable#4226slorber merged 2 commits intofacebook:masterfrom juancarlosjr97:patch-1
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 11db847 https://app.netlify.com/sites/docusaurus-1/deploys/602b7f3cf1a84e00081ebfd4 |
|
Size Change: +13 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 11db847 |
| import myImageUrl from './assets/docusaurus-asset-example-banner.png'; | ||
|
|
||
| <img src={myImageUrl)} alt="My image alternative text" /> | ||
| <img src={myImageUrl} alt="My image alternative text" /> |
There was a problem hiding this comment.
thanks
Can you do that change in /website/docs/markdown-features.mdx too please?
There was a problem hiding this comment.
Good catch 👍
There was a problem hiding this comment.
Did you mean by website/docs/guides/markdown-features/markdown-features-assets.mdx right @slorber ?
There was a problem hiding this comment.
yes, the same file in the upstream version so that it's not lost on alpha 71 when we release it ;)
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4226--docusaurus-2.netlify.app/classic/ |
Removing a wrong parenthesis on image variable.