Skip to content

fix(v2): typo in resolve.roots#4212

Merged
slorber merged 1 commit intomasterfrom
slorber/fix-webpack-typo-resolve.roots
Feb 10, 2021
Merged

fix(v2): typo in resolve.roots#4212
slorber merged 1 commit intomasterfrom
slorber/fix-webpack-typo-resolve.roots

Conversation

@slorber
Copy link
Copy Markdown
Collaborator

@slorber slorber commented Feb 10, 2021

Motivation

Used the wrong constant name in webpack config

The constant name for static and build/assets is too similar, made the difference more explicit to avoid doing this typo again

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 10, 2021
@slorber slorber requested a review from lex111 as a code owner February 10, 2021 10:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 10, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 10, 2021

[V1] Deploy preview success

Built with commit df3fdce

https://deploy-preview-4212--docusaurus-1.netlify.app

@github-actions
Copy link
Copy Markdown

Size Change: 0 B

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 109 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.8 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB 0 B

compressed-size-action

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 10, 2021

Deploy preview for docusaurus-2 ready!

Built with commit df3fdce

https://deploy-preview-4212--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4212--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit 780afe5 into master Feb 10, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/fix-webpack-typo-resolve.roots branch August 17, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants