docs(v2): Added Console Table Documentation Site to showcase#4207
Merged
slorber merged 1 commit intofacebook:masterfrom Feb 10, 2021
ayonious:console-docu1
Merged
docs(v2): Added Console Table Documentation Site to showcase#4207slorber merged 1 commit intofacebook:masterfrom ayonious:console-docu1
slorber merged 1 commit intofacebook:masterfrom
ayonious:console-docu1
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 9061698 https://app.netlify.com/sites/docusaurus-1/deploys/6022b865f5bcd0000745fc4c |
|
Size Change: +20 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 9061698 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4207--docusaurus-2.netlify.app/classic/ |
Collaborator
|
thanks |
slorber
reviewed
Feb 10, 2021
| title: 'Console Table', | ||
| description: 'Printing Pretty Tables on your console.', | ||
| preview: require('./showcase/console-table.png'), | ||
| website: 'https://console-table.netlify.app/', |
Collaborator
There was a problem hiding this comment.
FYI @lex111 I think it's fine to accept Netlify domains like that, as long as it's a "production/stable" domain, without a random deployment number. It's a free hosting solution and not worst than accepting GH pages domains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I created documentation site for a npm package Console Table Printer. I would like to showcase it in Docusaurus's Gallery.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Ran the project with
yarn startand went to showcase tab.Saw my project listed there.
Related PRs
None