Skip to content

docs(v2): Add react-hooks.org to showcase#4172

Merged
slorber merged 7 commits intofacebook:masterfrom
imbhargav5:patch-1
Feb 4, 2021
Merged

docs(v2): Add react-hooks.org to showcase#4172
slorber merged 7 commits intofacebook:masterfrom
imbhargav5:patch-1

Conversation

@imbhargav5
Copy link
Copy Markdown
Contributor

@imbhargav5 imbhargav5 commented Feb 4, 2021

Motivation

I built react-hooks.org entirely with docusaurus and I would like to add it to it's showcase.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Just changed the a JSON file. I don't know if it requires any tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 4, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2021

[V1] Deploy preview failure

Built without sensitive environment variables with commit 1008cf4

https://app.netlify.com/sites/docusaurus-1/deploys/601bd3798f8298000780dbb5

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2021 •
edited
Loading

[V1] Deploy preview failure

Built without sensitive environment variables with commit 3a89423

https://app.netlify.com/sites/docusaurus-1/deploys/601bd92633d8f50008735969

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2021

Deploy preview for docusaurus-2 failed.

Built without sensitive environment variables with commit 1008cf4

https://app.netlify.com/sites/docusaurus-2/deploys/601bd3795f4c5500099b335c

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2021 •
edited
Loading

Size Change: +17 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 109 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB +3 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.94 kB 0 B

compressed-size-action

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2021

Deploy preview for docusaurus-2 failed.

Built without sensitive environment variables with commit 3be3b96

https://app.netlify.com/sites/docusaurus-2/deploys/601bd3c5e29d9800076b9c5a

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2021 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 3a89423

https://deploy-preview-4172--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4172--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 4, 2021
@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Feb 4, 2021

thanks :)

@slorber slorber changed the title Add react-hooks.org to showcase docs(v2): Add react-hooks.org to showcase Feb 4, 2021
@slorber slorber merged commit f788ba4 into facebook:master Feb 4, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lex111 lex111 Awaiting requested review from lex111

@slorber slorber Awaiting requested review from slorber

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Milestone

v2.0.0-alpha.71

Development

Successfully merging this pull request may close these issues.

4 participants

@imbhargav5 @slorber @lex111 @facebook-github-bot