Skip to content

Added Hashnode support site to showcase#4171

Merged
lex111 merged 3 commits intofacebook:masterfrom
iamshadmirza:master
Feb 8, 2021
Merged

Added Hashnode support site to showcase#4171
lex111 merged 3 commits intofacebook:masterfrom
iamshadmirza:master

Conversation

@iamshadmirza
Copy link
Copy Markdown
Contributor

@iamshadmirza iamshadmirza commented Feb 4, 2021

Motivation

We built Hashnode support site using docusaurus and want to showcase that on the /showcase page

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I updated the files inside website/src/data/users and tested them by running yarn start

Related PRs

None
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @iamshadmirza!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2021

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2021

Size Change: -39 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB -72 B (0%)
website/build/assets/js/main.********.js 109 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB +16 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB +3 B (0%)

compressed-size-action

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 4897b47

https://deploy-preview-4171--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 83
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4171--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Feb 4, 2021

thanks for choosing docusaurus 👍

just waiting for the CLA signature process to complete before being able to merge

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Feb 5, 2021

@iamshadmirza can you please sign the FB CLA?

Unfortunately, I'm unable to merge this PR without it

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 8, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iamshadmirza
Copy link
Copy Markdown
Contributor Author

Hey @slorber, the CLA is signed. You can merge the PR now. Sorry for the delay.

@lex111 lex111 merged commit b0e38d5 into facebook:master Feb 8, 2021
@lex111
Copy link
Copy Markdown
Contributor

lex111 commented Feb 8, 2021

@iamshadmirza thanks!

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants