Skip to content

refactor(v2): minor styling improvements#4167

Merged
slorber merged 2 commits intomasterfrom
lex111/minor-styling
Feb 4, 2021
Merged

refactor(v2): minor styling improvements#4167
slorber merged 2 commits intomasterfrom
lex111/minor-styling

Conversation

@lex111
Copy link
Copy Markdown
Contributor

@lex111 lex111 commented Feb 3, 2021

Motivation

  • Fix borders of collapse doc sidebar button

  • Replace e-resize type with click when hover on expand sidebar button

Before After
image image

  • Add hover state for dark mode switcher

  • Use Infima buttons on home page

Before After
image image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 3, 2021
@lex111 lex111 requested a review from slorber as a code owner February 3, 2021 17:47
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 3, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 3, 2021 •
edited
Loading

[V1] Deploy preview success

Built with commit 8dc02eb

https://deploy-preview-4167--docusaurus-1.netlify.app

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 3, 2021 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 8dc02eb

https://deploy-preview-4167--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2021 •
edited
Loading

Size Change: +15 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.7 kB 0 B
website/build/assets/js/main.********.js 109 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB +1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB 0 B

compressed-size-action

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4167--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Feb 3, 2021 •
edited
Loading

Thanks

Was not totally satisfied with my homepage button 😅

There are some responsive problems thoughts. Also wonder if it's not better to keep the text white for dark mode?

The rest looks fine to me

image

image

@lex111
Copy link
Copy Markdown
Contributor Author

lex111 commented Feb 3, 2021

There are some responsive problems thoughts. Also wonder if it's not better to keep the text white for dark mode?

Responsive design issues fixed, as for the color it's hard for me to make a decision - I think the default color looks good.

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Feb 4, 2021

thanks, we can see later to improve if needed :)

@slorber slorber merged commit dbfa256 into master Feb 4, 2021
@lex111 lex111 deleted the lex111/minor-styling branch February 19, 2021 18:20
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber Awaiting requested review from slorber

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Milestone

v2.0.0-alpha.71

Development

Successfully merging this pull request may close these issues.

3 participants

@lex111 @slorber @facebook-github-bot