fix(v2): correct typo in metas generated for Twitter cards#3900
Merged
slorber merged 1 commit intofacebook:masterfrom Dec 10, 2020
mpsq:mp-twitter
Merged
fix(v2): correct typo in metas generated for Twitter cards#3900slorber merged 1 commit intofacebook:masterfrom mpsq:mp-twitter
slorber merged 1 commit intofacebook:masterfrom
mpsq:mp-twitter
Conversation
The Open Graph protocol format is the following: ``` <meta property="og:image" content="https://example.com/image.png /> ``` Twitter metas, however, are structured in a different format: ``` <meta name="twitter:image" content="https://example.com/image.png /> ``` They are similar but not identical, I think this led to confusion and the typo we have in the codebase.
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: ca5722c 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fd2455b6307fd144317b87f 😎 Browse the preview: https://deploy-preview-3900--docusaurus-2.netlify.app |
|
Size Change: 0 B Total Size: 154 kB ℹ️ View Unchanged
|
Collaborator
|
Thanks @markerikson FYI that might impact your customization on Redux sites? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Open Graph protocol format is the following:
Twitter metas, however, are structured in a different format:
They are similar but not identical, I think this led to confusion and
the typo we have in the codebase.