fix(v2): do not treat at-rules during CSS minification#3896
Merged
Conversation
slorber
approved these changes
Dec 8, 2020
Collaborator
slorber
left a comment
There was a problem hiding this comment.
LGTM, strange that it does not work but we'd rather disable this for now
|
Size Change: 0 B Total Size: 154 kB ℹ️ View Unchanged
|
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: 895e18c 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fcf9dfe640fb8000715789a 😎 Browse the preview: https://deploy-preview-3896--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3896--docusaurus-2.netlify.app/classic/ |
Contributor
|
Confirmed same issue, hope this gets released soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3836
This disables the
removeUnusedAtRulesoption in advanced CSS minifier as it does not work correctly for us.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested on https://github.com/semoal/docusaurus-css-minifier-bug (after that, the building of site goes without fatal errors).
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)