chore(ci): run V1 Build and Migration CLI tests conditionally on CI#3863
Merged
slorber merged 6 commits intofacebook:masterfrom Dec 2, 2020
Merged
chore(ci): run V1 Build and Migration CLI tests conditionally on CI#3863slorber merged 6 commits intofacebook:masterfrom
slorber merged 6 commits intofacebook:masterfrom
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit d0d667b |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3863--docusaurus-2.netlify.app/classic/ |
|
Size Change: 0 B Total Size: 157 kB ℹ️ View Unchanged
|
Collaborator
|
Thanks :) |
slorber
reviewed
Dec 11, 2020
| outputs: | ||
| migration: ${{ steps.filter.outputs.migration }} | ||
| steps: | ||
| - uses: dorny/paths-filter@v2 |
Collaborator
There was a problem hiding this comment.
strange that it works because on another brranch it fails due to missing git checkout step (I think)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is an attempt to optimize CI workflows a bit more to improve the time required to check every PR.
I have utilized the
@dorny/paths-filteraction to add check based on the modified files in the PR so now:packages/docusuaurs-1.xorpackages/docusuaurs-init-1.xfiles have been changed.packages/docusuaurs-migrationincludes the changes.This is the first time I have used this action, so the initial version might be not correct. Any tips and ideas for further optimizations are welcome!
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Run the CI! 😉
Related PRs