chore(ci): CI scripts cleanup, add Node 14 runs, bump checkout action#3849
Merged
slorber merged 12 commits intofacebook:masterfrom Dec 1, 2020
Merged
Conversation
slorber
reviewed
Nov 30, 2020
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit b32bf8e |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3849--docusaurus-2.netlify.app/classic/ |
|
Size Change: +21 B (0%) Total Size: 157 kB ℹ️ View Unchanged
|
Contributor
Author
|
Changing Node from
|
Collaborator
|
Thanks, seems to be fine for now, but we'll try to figure out these issues you reported |
This was referenced Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR clean up the GitHub action workflow files and adds Node 14 run to the "Yarn v1 E2E" run and Node 15 to the "Yarn v2 E2E" run to ensure that not only the minimal version of Node, but also
Active LTSandCurrentdo no produce any errors for the users.I have also bumped all the remaining
actions/checkout@v1tov2- some of workflows were already usingv2. Also the Node version declaration has been updated to the recommended syntax - https://github.com/actions/setup-node.Additionally I have moved the Yarn version set command at the beginning of script so initial installation would also be performed using Yarn v2.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Need to run the CI.
Related PRs
No.