Skip to content

ci(v2): test swizzle on CI using v2 website#3840

Closed
Simek wants to merge 12 commits intofacebook:mainfrom
Simek:ci-test-swizzle-on-v2
Closed

ci(v2): test swizzle on CI using v2 website#3840
Simek wants to merge 12 commits intofacebook:mainfrom
Simek:ci-test-swizzle-on-v2

Conversation

@Simek
Copy link
Copy Markdown
Contributor

@Simek Simek commented Nov 29, 2020

Motivation

#3830 - as reported, there is an issue with swizzled component form theme-classic right now.

To prevent new swizzling errors from slipping into the release I have decided to add the swizzle test of most of theme-classic, theme-search-algolia and theme-live-codeblock components to the CI pipeline. Test is based on the Docusuaurs V2 website and helper scripts starting with swizzle:v2 have been added to the main package.json.

The list of components is subjective, feel free to change or update it 🙂

Currently the test step will fail for:

  • DocPage and DocSidebar components due to the same error as reported in the mentioned issue

    ModuleNotFoundError: Module not found: Error: Can't resolve '../icons/arrow.svg'

After fixing those problem the step run should be successful.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Manual command run and test builds on local. After publish

Related PRs

No.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 29, 2020
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 29, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 89b958e

https://deploy-preview-3840--docusaurus-2.netlify.app

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 29, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 08b1a82

https://deploy-preview-3840--docusaurus-2.netlify.app

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Nov 30, 2020

Thanks, that's a good test idea 👍

We should probably ensure the test pass before merging 😅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3840--docusaurus-2.netlify.app/classic/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2020

Size Change: +15 B (0%)

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB +2 B (0%)

compressed-size-action

@Simek Simek force-pushed the ci-test-swizzle-on-v2 branch from 9ad6395 to 3d63a1a Compare December 23, 2020 15:03
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 16, 2021

@Simek
Copy link
Copy Markdown
Contributor Author

Simek commented Feb 16, 2021

FYI: From the day when #3854 has been merged (Dec 01, 2020), running all the commands locally, in same order as in workflow results in successful build. The server compilation seems to fail only on the CI. I have tried many ideas to fix this, all of them failed.

To be honest, I don't want to waste any minute more on this problem, @slorber can you step in?

@Simek Simek closed this Sep 17, 2021
@Simek Simek deleted the ci-test-swizzle-on-v2 branch September 17, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants