test(v2): Add bootstrap tests e2e#3468
test(v2): Add bootstrap tests e2e#3468fanny wants to merge 2 commits intofanny/migrate-bootstrap-to-tsfrom
Conversation
|
Thanks @fanny Was wondering if we couldn't make the Cypress test suite theme-agnostic? As we are going to have classic/bootstrap and maybe other full-featured themes (all supporting blog, docs, pages...), what would be nice is if we were able to share the same integration test suite for multiple themes, as long as they share the same testIds or aria selectors? After all, all themes will likely need to paginate between blog post and have next/previous navigation. Don't know if it's a viable solution, just an idea I had. Maybe the plan is not to have exactly the same set of features for all themes and could be hard to achieve? |
|
Hi @fanny! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
No longer relevant, since the Bootstrap theme has been removed from the codebase. |
Motivation
Implement a simple mechanism to E2E test. Recently some APIs that we had, it was changed and it caused some bugs in boostrap theme.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
bootstraptemplateyarn test-e2eRelated PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)