fix(gtag.js, faster): Fix StackBlitz, vendor @types/gtag.js, upgrade @swc/html #12080
Merged
Conversation
@types/gtag.js, upgrade @swc/html
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12 MB ℹ️ View Unchanged
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.4 MB ℹ️ View Unchanged
|
|
Just seeing this now- @slorber FYI the reason gtag.js dep fails is that, you are running an ad blocker extension and it automatically fails any requests that have |
Collaborator
Author
|
Damn, thanks for the update! Now that you said it, it's so obvious 😅 I'll still ship the change because I'm probably not alone having an ad blocker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11615
Fix #12008
Let's force bump
@swc/htmlto a version that works within StackBlitzAlso, I'm interning on the
@types/gtag.jspackage because, for an unknown reasons, this specific dependency has been causing troubles in StackBlitzTest Plan
CI
Test links
https://deploy-preview-12080--docusaurus-2.netlify.app/