fix(bundler): do not import @swc/html, fix StackBlitz playground#12055
Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.5 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #12008
For now there's a Wasm binding bug in
@swc/htmlthat prevents it from loading in StackBlitz playground: swc-project/swc#11833With Docusaurus Faster enabled by default in v3.10, our StackBlitz playground is broken due to that issue, because the problematic dependency is imported eagerly.
Until they release the fix, I'd like to fix our playground by loading that dependency lazily, which is more performant anyway because this package is not needed until minimization.
This permits:
yarn startin StackBlitzSKIP_HTML_MINIFICATION=true yarn buildin StackBlitz, until the upstream gets officially solvedTest Plan
CI + local tests