fix(theme): remove "Edit this page" button from print view #11463
Conversation
|
Hi @richk21! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hi @slorber @Josh-Cena can you please review this PR? Fixes #11462 and https://docusaurus.io/feature-requests/p/hide-edit-this-page-when-printing |
Josh-Cena
left a comment
There was a problem hiding this comment.
I personally think this is a good idea. Thanks :)
slorber
left a comment
There was a problem hiding this comment.
thanks, agree it's an improvement 👍
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-11463--docusaurus-2.netlify.app/
Related issues/PRs
Fixes #11462