fix(docs): Fix empty sidebar item category className lost when post-processed to a doc
#11281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ategory gets post-processed to a doc
docs/dirName/index.mdclassName lost when post-processed to a doc
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
7 tasks
|
Size Change: +1.97 kB (+0.02%) Total Size: 11.5 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +1.96 kB (+0.02%) Total Size: 11.9 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11258
Normally the
docs/<dirName>/index.mdFS pattern leads to a category that links to the index doc.But when this is the only doc of that category, it doesn't make sense to show a collapsible category if there's no subitem in it, so the sidebar post-processor transforms the category as a standard doc link.
During that transformation, the category
classNameandcustomPropswere not propagated correctlyTest Plan
Unit tests + Dogfood in deploy preview
Test links
https://deploy-preview-11281--docusaurus-2.netlify.app/tests/docs/tests/sidebar-frontmatter/dir-with-unique-index