fix(core): fix React rendering null chars in HTML output - Use renderToReadableStream#10562
Closed
slorber wants to merge 6 commits into
Closed
fix(core): fix React rendering null chars in HTML output - Use renderToReadableStream#10562slorber wants to merge 6 commits into
renderToReadableStream#10562slorber wants to merge 6 commits into
Conversation
renderToReadableStreamrenderToReadableStream
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
7 tasks
|
Size Change: +238 B (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
Collaborator
Author
|
Although it seems to work and fix the bug, we might not want to merge it. |
Collaborator
Author
|
Bug fixed in React 19: react/react#31134 Also fixed when using our new faster minifier: #9985 (comment) So this change is not needed anymore, the original bug will automatically fix itself once we upgrade React or turn the new HTML minifier on by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #9985
Replace
renderToPipeableStreamwithrenderToReadableStreambecause the former emit NULL chars unexpectedly, which might be a React bug.Note: the setup is not super clean in terms of TS/exports, but it should work for all versions of Node we cover or the CI would report it.
Note: I benchmarked this locally and I doubt this has a significant impact on Docusaurus build times: it's approximately the same. The app rendering phase is not our main bottleneck currently, even with the new Docusaurus Faster options.
Related links:
renderToPipeableStreamreact/react#31134Test Plan
CI
Test links
https://deploy-preview-10562--docusaurus-2.netlify.app/