fix(tsconfig): add @docusaurus/tsconfig target es2022
#10547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +228 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sites using TypeScript should support TS syntax up to ES2022 as a reasonable default.
Also advised in https://www.totaltypescript.com/tsconfig-cheat-sheet
It's only a default, that I think has been forgotten when creating the initial
@docusaurus/tsconfigpackage, so I consider this as a bugfix.(users can revert it to the "es5" default TS value if they want)
Now it's hard to find a "perfect" default because feature support increases other time and we are not sure if users will use TS for Node or React theme code.
I noticed this lack of a better default while working on Rspack with skipLibCheck=false leading to errors such as:
Test Plan
CI
Test links
https://deploy-preview-10547--docusaurus-2.netlify.app/