gha: run tests using faasmctl #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32ac622 to
006f777
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 68.14% 68.14%
=======================================
Files 71 71
Lines 6987 6987
=======================================
Hits 4761 4761
Misses 2226 2226 ☔ View full report in Codecov by Sentry. |
4d4a219 to
87dac4b
Compare
8d2fd07 to
9fb866d
Compare
9fb866d to
8a9ab48
Compare
0696950 to
b0195ab
Compare
36332e5 to
0ecc757
Compare
83d39e1 to
8d10419
Compare
8d10419 to
3bc78be
Compare
4a3489c to
5948d74
Compare
5948d74 to
1988c3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies, unifies, and improves the performance of our GHA jobs.
The background motivation is that, after moving to LLVM 17, building
dev.toolsinside a GHA's hosted container runs out of disk space.We have been down this road before, this already happened with the SGX tests. Our current fix is to use an action to free disk space in the runner. The action works great and it frees dozens of GBs, so it should be stable enough in the middle term.
Unfortunately, this action can only be used on regular (i.e. non-containerised) GHA jobs. Thus, we move the main
testsjob matrix to usefaasmctl.In the process, I have spent some time building an action that caches the pulling of all the docker images we use as part of all the tests: https://gitub.com/faasm/image-cache-action
This also greatly speeds-up image pulling time. Currently, getting all the images to deploy a cluster ready to run can be done in < 5', and is bound by the CPU running
docker load.By carefully controlling the outputs of the cache, together with the conan cache, we can be ready to run the tests in 16'. Of this:
faasmctlclusterThe lowest-hanging fruit to push this further down is to improve the test building time. We sill build a some dependencies every time we built the tests:
nng,zstd,wavm,wamr, andaws-sdk-cpp.In the future I would like to move some of those to Conan (again!).