Skip to content

openmp: abstract implementation from WAVM to WASM #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csegarragonz merged 11 commits into from
Jan 5, 2024
Merged

openmp: abstract implementation from WAVM to WASM #811

csegarragonz merged 11 commits into from
Jan 5, 2024

Conversation

@csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Dec 18, 2023

No description provided.

@csegarragonz csegarragonz marked this pull request as draft December 18, 2023 17:41
@csegarragonz csegarragonz changed the title openmp: pre-load scheduling decision if request is singleHost openmp: add basic WAMR support for OpenMP Jan 3, 2024
@csegarragonz csegarragonz changed the title openmp: add basic WAMR support for OpenMP openmp: abstract methods from WAVM to WASM Jan 4, 2024
@csegarragonz csegarragonz changed the title openmp: abstract methods from WAVM to WASM openmp: abstract implementation from WAVM to WASM Jan 4, 2024
@csegarragonz csegarragonz mentioned this pull request Jan 4, 2024
Closed
@csegarragonz csegarragonz marked this pull request as ready for review January 4, 2024 15:51
@codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (adf299b) 67.50% compared to head (e756b2a) 67.63%.

Files Patch % Lines
src/wasm/openmp.cpp 83.97% 29 Missing ⚠️
src/wavm/openmp.cpp 88.88% 2 Missing ⚠️
src/wasm/WasmModule.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   67.50%   67.63%   +0.13%     
==========================================
  Files          69       71       +2     
  Lines        7764     7811      +47     
==========================================
+ Hits         5241     5283      +42     
- Misses       2523     2528       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csegarragonz csegarragonz merged commit f5daca3 into main Jan 5, 2024
@csegarragonz csegarragonz deleted the preload-omp branch January 5, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csegarragonz