feat: add e2e tests #783
Merged
feat: add e2e tests #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c5223e to
50231b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
+ Coverage 67.55% 67.57% +0.02%
==========================================
Files 71 71
Lines 7884 7884
==========================================
+ Hits 5326 5328 +2
+ Misses 2558 2556 -2 ☔ View full report in Codecov by Sentry. |
7a180f8 to
a37c22c
Compare
869061f to
3e9c9c3
Compare
…to relevant issue
3a45286 to
cd02a65
Compare
cd02a65 to
502ea51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
faasmctlit is now much easier to write end-to-end tests with small bash scripts.Note that the choice of bash over python is deliberate, we want to make the e2e tests as close as real use-cases as possible. In particular, I imagine that we can add e2e tests whenever an issue is raised that some interaction with a Faasm cluster does not work as expected (e.g. #773 or #830).
In GHA, we run the e2e tests both mounting or not mounting the source code (i.e. latest tag, or latest commit) and
wavmandwamr.Closes #533