Format code in a specific directory #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 67.47% 67.40% -0.07%
==========================================
Files 69 69
Lines 7760 7760
==========================================
- Hits 5236 5231 -5
- Misses 2524 2529 +5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I update the code-formatting task to take an optional parameter
cwdindicating what directory to format code in.This is useful when working on one submodule (e.g. faabric or CPP) checked-out as a submodule of Faasm (and not as a standalone repo). In this case, the native formatting (in faabric or CPP) won't work, as the mounted
.gitdirectory (used to rungit ls-files) points to a non-existant parent module.Now, we can run:
inv format-code --cwd ./faabricfrom Faasm's CLI container to fix this issue.