Use Semantic Versioning #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #775 +/- ##
==========================================
- Coverage 67.43% 67.40% -0.03%
==========================================
Files 69 69
Lines 7729 7729
==========================================
- Hits 5212 5210 -2
- Misses 2517 2519 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I move Faasm and its tightly coupled dependencies (faasm/faabric#334, faasm/cpp#120, and faasm/python#30) to use semantic versioning, or SemVer.
Admittedly, Faasm doesn't expose a stable API, and it will never reach a stable version (i.e.
>=1.0.0according to SemVer). Still, SemVer provides some rationale re. when to tag a new version. Whereas until now we had no rationale at all (only whenever we wanted a new container image).In summary, with SemVer:
minorversion (inv git.bump --minor) any time we introduce a new feature.patchversion (inv git.bump --patch) any time we fix a bug.We are still a bit selective wrt to what is a feature and what is a bug, and it will still be ultimately arbitrary. But at least it provides a bit more order.
In addition, I also move the tasks to bump tracked dependencies to
inv git.bump-dep [--faabric,cpp,python,faasmctl], and bump thefaasmctlversion to fix the Azure integration tests.