Skip to content

Conversation

@csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Jul 18, 2023

In this PR I make the ports that we expose in docker compose configurable via environment variables. This allows to run more than one Faasm development cluster on the same host machine without binding to the same address.

For reference, we implement this in faasm/faasmctl#25

@csegarragonz csegarragonz marked this pull request as ready for review July 19, 2023 08:50
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #774 (165b676) into main (1c90ed8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files          69       69           
  Lines        7729     7729           
=======================================
  Hits         5212     5212           
  Misses       2517     2517           

@csegarragonz csegarragonz merged commit 4aa6888 into main Jul 19, 2023
@csegarragonz csegarragonz deleted the concurrent-compose branch July 19, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants