Invoke planner #770
Merged
Invoke planner #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68f7a88 to
057d048
Compare
057d048 to
52a15d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #770 +/- ##
==========================================
+ Coverage 67.35% 67.43% +0.07%
==========================================
Files 69 69
Lines 7729 7729
==========================================
+ Hits 5206 5212 +6
+ Misses 2523 2517 -6
|
1a81f4f to
7a353e9
Compare
7a353e9 to
d971254
Compare
d1d7b88 to
db57325
Compare
860d4dc to
3e8be92
Compare
3e8be92 to
e40ca10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we move function invocation from the worker (via
nginx) to the planner.In terms of C++ source code, the only changes are to accomodate for some ABI changes in faasm/faabric#330. In particular: (i) refactor
req->id()toreq->appid(), and (ii) movebatchExecuteFactorytoinclude/faabric/util/batch.h.We also move the quick start tests, and the
upload/invoketasks, to usingfaasmctlunder the hood. This is just a small change, the fullfaasmctloverhaul (where we will get rid offaasmcli) will happen in a separate PR.