-
Notifications
You must be signed in to change notification settings - Fork 70
GHA Improvements #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
GHA Improvements #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68f13af to
420b633
Compare
9971c72 to
f63be12
Compare
e46c55f to
f3f81c1
Compare
f3f81c1 to
c877372
Compare
a4b3c3f to
71a96d6
Compare
Codecov Report
@@ Coverage Diff @@
## main #763 +/- ##
==========================================
+ Coverage 67.34% 67.42% +0.07%
==========================================
Files 69 69
Lines 7726 7726
==========================================
+ Hits 5203 5209 +6
+ Misses 2523 2517 -6 |
71a96d6 to
071fde5
Compare
071fde5 to
ef5cada
Compare
360f7b9 to
5954d49
Compare
5954d49 to
d5648e3
Compare
4fca115 to
f021fa7
Compare
f021fa7 to
d68114a
Compare
d6f4af2 to
8e2f261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the GHA jobs take around 45' to complete, what really slows down the development cycle. In this PR I introduce a number of improvements to the main integration test workflow.
First, the
cpp-funcsandpy-funcssteps only need to be re-run if there are any changes in theclients/cppandclients/pythonsubmodules respectively. Unfortunately, theupload-artifactaction only works within a workflow run, and not accross workflow runs, so we can't use previous run's artifacts easily. Instead, we use a cache for WASM code. In summary, thecpp-funcsandpy-funcsonly run if there are changes or the cache has expired. (As a sidenote, GHA's caches have a versioning that depends on the compression algorithm used, which is different inside and outside a container, so we must make sure they are the same by installingzstdin the containers).Secondly, a lot of time is spent building the codegen binary without sanitisers, and then re-building the tests again with sanitisers enabled. We make a couple of observations:
cpporpythonhave changed, or (ii)cppandpythonhave not changed, but we have a machine code cache miss (i.e. new CPU).codegen_funcbinary if we need to re run the codegen, and not always.