Skip to content

Conversation

@csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented May 31, 2023

There's some confusion throughout the codebase about wether the outputData field of the protobuf is treated as a string or as bytes. This field is used to populate result.outputdata() which we usually want to manipulate/display/return to the user. As a consequence, I think it make sense to make the parameter a string.

The only reason we can't really do this with inputData just yet, is because for the code generation we set the inputdata to the WASM file (as a byte array).

@csegarragonz csegarragonz self-assigned this Jun 1, 2023
@csegarragonz csegarragonz mentioned this pull request Jun 1, 2023
45 tasks
@csegarragonz csegarragonz merged commit 60f62df into main Jun 1, 2023
@csegarragonz csegarragonz deleted the outputdata-string branch June 1, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants