-
Notifications
You must be signed in to change notification settings - Fork 70
Fixes for (non)-dev clusters and quick-start tests
#746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker compose clusters
docker compose clustersquick-start tests
…y available when code is mounted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GHA file to run a version of the
quick-starttests with the latest checked-out version of the code.In the process, I realised that the targets where re-built even though we started the cluster in non-development mode. This is, the following:
would re-build the
pool_runnerbinary from scratch.This is because we were also mounting both (i) the host's
pwdin/usr/local/code/faasmand (ii) the host's Conan cache in/root/.conan. This PR adds two environment variables that make the hostspwdand conan-cache point to garbage directories in the container unless invoked via./bin/cli.sh.The various configurations of (non)-dev clusters and env. variables are getting a bit out of hand. In coming PRs I would like to:
./bin/cli.shto aninvtaskfaasmcli, maintainfaasmclias a separate repository, and move all non-cluster related tasks to a regulartasksdirectory in faasm.