Skip to content

Conversation

@csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented May 3, 2023

This PR updates the GHA file to run a version of the quick-start tests with the latest checked-out version of the code.

In the process, I realised that the targets where re-built even though we started the cluster in non-development mode. This is, the following:

docker compose up -d nginx --scale worker=2
docker compose run --rm -T faasm-cli ./bin/inv_wrapper.sh dev.cc pool_runner

would re-build the pool_runner binary from scratch.

This is because we were also mounting both (i) the host's pwd in /usr/local/code/faasm and (ii) the host's Conan cache in /root/.conan. This PR adds two environment variables that make the hosts pwd and conan-cache point to garbage directories in the container unless invoked via ./bin/cli.sh.

The various configurations of (non)-dev clusters and env. variables are getting a bit out of hand. In coming PRs I would like to:

  • Move ./bin/cli.sh to an inv task
  • Move all cluster/deployment related tasks into faasmcli, maintain faasmcli as a separate repository, and move all non-cluster related tasks to a regular tasks directory in faasm.

@csegarragonz csegarragonz changed the title gha: mount code for quick start test Fully isolated mode for non-dev docker compose clusters May 3, 2023
@csegarragonz csegarragonz changed the title Fully isolated mode for non-dev docker compose clusters Fixes for (non)-dev clusters and quick-start tests May 3, 2023
@csegarragonz csegarragonz mentioned this pull request May 3, 2023
45 tasks
@csegarragonz csegarragonz merged commit 1a326cb into main May 30, 2023
@csegarragonz csegarragonz deleted the mount-qs branch May 30, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants